Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app env vars override issue #26

Merged
merged 12 commits into from
Sep 22, 2023
Merged

fix: app env vars override issue #26

merged 12 commits into from
Sep 22, 2023

Conversation

wrn14897
Copy link
Contributor

Users now should be able to specify custom api + app + otel collector URLs in the .env file and rebuild the images for self-hosting by running make build-local

Address the ticket #12

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 59252ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MikeShi42
MikeShi42 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@wrn14897 wrn14897 merged commit 4405d78 into main Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeShi42 MikeShi42 MikeShi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrn14897 @MikeShi42